Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resiliency ubi-micro image #168

Merged
merged 26 commits into from
Aug 4, 2023
Merged

Resiliency ubi-micro image #168

merged 26 commits into from
Aug 4, 2023

Conversation

IsaiasA1
Copy link
Contributor

@IsaiasA1 IsaiasA1 commented Jul 6, 2023 •
edited by shaynafinocchiaro
Loading

Description

Implementation of ubi-micro image for karavi-resiliency

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#922

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • powerflex-integration-test
  • powerscale-integration-test
  • powerstore-integration-test
  • unity-integration-test

@IsaiasA1 IsaiasA1 changed the title Testing ubi micro Resiliency ubi-micro image Jul 6, 2023
@IsaiasA1 IsaiasA1 marked this pull request as ready for review July 6, 2023 14:26
PeresKereotubo
PeresKereotubo previously approved these changes Jul 6, 2023
View reviewed changes
@hoppea2
Copy link
Collaborator

hoppea2 commented Jul 24, 2023

@IsaiasA1 Are we holding off on the PR for a specific reason? Thanks!

@dell dell deleted a comment from IsaiasA1 Jul 24, 2023
alikdell
alikdell previously approved these changes Jul 25, 2023
View reviewed changes
@IsaiasA1 IsaiasA1 dismissed stale reviews from shaynafinocchiaro and alikdell via f01ae87 July 27, 2023 19:17
@xuluna xuluna merged commit befedcf into main Aug 4, 2023
6 checks passed
@xuluna xuluna deleted the testing-ubi-micro branch August 4, 2023 18:10
@xuluna xuluna mentioned this pull request Aug 16, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@aqu-dell aqu-dell Awaiting requested review from aqu-dell

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@PeresKereotubo PeresKereotubo Awaiting requested review from PeresKereotubo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@IsaiasA1 @hoppea2 @alikdell @shaynafinocchiaro @PeresKereotubo @xuluna